[PATCH] date format addition

lirit

Hey,

See my patch to add another date format to the select list for the RegionalSettings module.
I haven't seen the possibility to re-install this module, how do I refresh it then with this new setting?

Since .diff extension is not allowed I renamed it to .gif

ethnar

You don't refresh it, it should be there automatically. 🙂 Make sure to have disabled/flushed cache/common.php
You can also change default via admin's menu.

shahidt

Hi. Does simply adding '%d/%m/%Y' solve all your issues. I modified the module file as below to have the effect right after setup. However, it breaks in the Events module - I tried Phone Call. When I create a new Phone Call from SO window, the date shows as 29/05/2012 (reflecting the addition of d/m/y format), but on Save it says field required and the date changes to 1969 year. I tried again with Chrome with the same result. Then I changed the date to one of the other default options and the record saved properly. I guess, I need to check the Common codes.

$date_formats_proto = array('%Y-%m-%d','%m/%d/%Y','%d/%m/%Y','%d %B %Y','%d %b %Y','%b %d, %Y');

ethnar

Hello,

The dd/mm/YYYY format is not a valid date format for the purpose of date processing in php. When using forward slashes, the correct format is mm/dd/YYYY.

Please execute the following code to test it firsthand:

<?php

$date = strtotime('2012-05-28');

$formats = array(

	'd/m/Y',

	'm/d/Y',

	'd/m/y',

	'm/d/y'

);

foreach ($formats as $d)

	print(date($d, $date).' is parsed as '.date('Y-m-d', strtotime(date($d, $date))).'<br>');

?>

The results:

28/05/2012 is parsed as 1970-01-01

05/28/2012 is parsed as 2012-05-28

28/05/12 is parsed as 1970-01-01

05/28/12 is parsed as 2012-05-28

Kind regards,
Arek

shahidt

Wow, I didn't know that. Thanks. Amazing what a hyphen or a slash can do to your life!!

This format should do I guess. 'd-m-Y'

Epesi ENS | Epesi Academy | epesi.cloud PaaS | GitHub

Help Me! | Download from SourceForge