Problems with module after upgrading to latest SVN

lirit

Hey guys

this is following the issue with adding an aggregated notes tab to sum all notes tab though it's not directly concerned with that but rather with the required upgrade I had to perform to latest Epesi SVN to support the aggregated notes tab passing of array() elements.

So after doing an 'svn update' - my module has 2 version, 0 and 1. The 0 version installed fine but only supplies 'some' functionality so I then went back to modules administration and upgraded to the 1 version of the module which caused the following errors to show up:



Type: 2

Message: Missing argument 3 for ModuleManager::satisfy_dependencies(), called in /var/www/crm/include/module_manager.php on line 357 and defined

File: /var/www/crm/include/module_manager.php

Line=185

error backtrace:

File: /var/www/crm/include/module_manager.php

    line 185

    function called: handle_epesi_error(2, "Missing argument 3 for ModuleManager::satisfy_dependencies(), called in /var/www/crm/include/module_manager.php on line 357 and defined", "/var/www/crm/include/module_manager.php", 185, Array ("University_Base", 1))

File: /var/www/crm/include/module_manager.php

    line 357

    function called: satisfy_dependencies("University_Base", 1)

File: /var/www/crm/modules/Base/Setup/Setup_0.php

    line 309

    function called: upgrade("University_Base", "1")

File: /var/www/crm/modules/Base/Setup/Setup_0.php

    line 208

    function called: validate(Array ("1", "0", Array (#142), "Base_Box", "/Base_Box|0/Base_Admin|main_b6b7b08facfdc5b280d14602eb6c5f6f/Base_Setup|0"))

File: /var/www/crm/modules/Base/Setup/Setup_0.php

    line 22

    function called: body()

[PHP core called function]

    function called: admin()

File: /var/www/crm/include/module.php

    line 793

    function called: call_user_func_array(Array (Object (Base_Setup), "admin"), Array ())

File: /var/www/crm/include/module.php

    line 713

    function called: get_html_of_module(Object (Base_Setup), null, "admin")

File: /var/www/crm/include/module.php

    line 883

    function called: display_module("Object (Base_Setup)", null, "admin")

File: /var/www/crm/modules/Base/Admin/Admin_0.php

    line 32

    function called: pack_module("Base_Setup", null, "admin")

[PHP core called function]

    function called: body()

File: /var/www/crm/include/module.php

    line 793

    function called: call_user_func_array(Array (Object (Base_Admin), "body"), Array ())

File: /var/www/crm/include/module.php

    line 713

    function called: get_html_of_module(Object (Base_Admin), null, null)

File: /var/www/crm/modules/Base/Box/Box_0.php

    line 148

    function called: display_module("Object (Base_Admin)")

File: /var/www/crm/include/epesi.php

    line 196

    function called: body()

File: /var/www/crm/include/epesi.php

    line 252

    function called: go(Object (Base_Box))

File: /var/www/crm/process.php

    line 32

    function called: process("_qf__libs_qf_79444ec36e550cbfffff813e57e7ea92.....");

and the result is that it doesn't install version 1 of the module...

shacky

Hi,
default value of check in satisfy_dependencies method (line 185) should be null...



private static function satisfy_dependencies($module_to_install,$version,$check=null) {

......

Thanks for bug report.
Paul

lirit

Hey Paul,

by creating a Notes History tab which lists the notes created by some tabs (you can see my previous post asking how to achieve that), when clicking in the Notes History tab I created on the History icon it errors:



Type: 2

Message: md5() expects parameter 1 to be string, array given

File: /var/www/crm/modules/Utils/Attachment/Attachment_0.php

Line=457

error backtrace:

[PHP core called function]

    function called: handle_epesi_error(2, "md5() expects parameter 1 to be string, array given", "/var/www/crm/modules/Utils/Attachment/Attachment_0.php", 457, Array (Object (Utils_Attachment), "64", Object (Base_Theme)))

File: /var/www/crm/modules/Utils/Attachment/Attachment_0.php

    line 457

    function called: md5(Array ("CRM/University/Base/TextCall17", "CRM/University/Base/TextMeeting17", "CRM/University/Base/MailText17"))

[PHP core called function]

    function called: edition_history("64")

File: /var/www/crm/include/module.php

    line 793

    function called: call_user_func_array(Array (Object (Utils_Attachment), "edition_history"), Array ("64"))

File: /var/www/crm/include/module.php

    line 713

    function called: get_html_of_module(Object (Utils_Attachment), Array ("64"), "edition_history")

File: /var/www/crm/modules/Base/Box/Box_0.php

    line 144

    function called: display_module("Object (Utils_Attachment)", Array ("64"), "edition_history")

File: /var/www/crm/include/epesi.php

    line 196

    function called: body()

File: /var/www/crm/include/epesi.php

    line 252

    function called: go(Object (Base_Box))

So I'm guessing it doesn't know how to handle an array and this is a bug... ?

ethnar

Hello,

I double-checked and the 1.1.3 version contains the change in Attachments that allows this module to handle multiple note groups in one instance.
The error you posted seems you're using older version.
Can you tell me where did you get 1.1.3 version from? Sourceforge svn or full download?

Kind regards,
Arek

lirit

I'm working with svn and I've tweaked the attachment_0.php code a bit just to add my
own custom date to a note (see my other post about it very recently) but I doubt those
changing are related to it.

I made an svn update and had nothing to update.

Regards,
Liran.

lirit

Arek,

If you look closely, the problem is that I'm passing to group to md5, such as: md5($this->group)
where $this->group is an array of several tabs...

my addon config is:



	public function my_base_summary_notes_addon($arg) {

		$groups = array('CRM/University/Base/TextCall'.$arg['id'], 

							'CRM/University/Base/TextMeeting'.$arg['id'],

							'CRM/University/Base/MailText'.$arg['id'],

					);

		...

the problem starts in the file Attachment_0.php:



edition_history($id) {

...

		$gb = $this->init_module('Utils/GenericBrowser',null,'hn'.md5($this->group));

...

ethnar

Yes, that is correct.

In 1.1.3 version the code in Attachment_0.php is

md5(serialize($this->group))

As I've seen you have problem with that exact line, this means Attachment is still of the older version (that and other changes are necessary for this method to work). I believe this is because Sourceforge svn was last updated with a revision within 1.1.3, but without this particular change.

We'll update Sourceforge svn version to our most recent revision which will include necessary Attachment module changes, I'll update this thread as soon as we update svn.

Kind regards,
Arek

lirit

svn info:
root@mba-lamp:/var/www/crm/modules/Utils/Attachment# svn info
Path: .
URL: https://epesi.svn.sourceforge.net/svnro ... Attachment
Repository Root: https://epesi.svn.sourceforge.net/svnroot/epesi
Repository UUID: 59f7bf6e-ec2c-0410-aebf-904d277dd207
Revision: 173
Node Kind: directory
Schedule: normal
Last Changed Author: shacky7
Last Changed Rev: 173
Last Changed Date: 2010-10-12 21:48:34 +0400 (Tue, 12 Oct 2010)

svn update says everything is up to date...
thanks, I'd appreciate if you could update me when the repo is updated.

ethnar

Hello,

We've just released version 1.1.4 of epesi. Sourceforge svn version was also updated to 1.1.4 and now includes changes to Attachment module that allows multiple notes groups to be displayed in one module instance.

Kind regards,
Arek

lirit

Thanks.
I was able to update cleanly just the Utils/Attachment folder and merge with my own changes in it (the addition of a Date field which is subject for changes by the user creating the notes and controls the created_on field).

But here's the thing -
Before the whole issues with the versions upgrade this bug was not present and now what happens is that even if I change the Date field (as shown in the screenshots attached) in the notes addon (as well as update the note's text) the field DOES change actually because if I edit it again after changing and saving then the new date is loaded indeed but in the notes listing, still this change doesn't appear..

I was hoping you'd have an idea for this...

in the edit note screen I change the note's text and the date itself

showing the incorrect date after being changed

ethnar

There are two possible scenarios:

First one - the update/modifications has overwritten/added code that resets the date back to default. Highly unlikely - I don't remember we added any code modifying date field and as you said - you did check it after update.

Second scenario - it's because of the trigger on created_on field in utils_attachment_file and utils_attachment_note. The one problem with ADODB is when you set default for a timestamp type field to current timestamp, it actually creates trigger "on update" that sets the date to current timestamp every time you trigger SQL update.
In this case - all you need to do is to remove that trigger from created_on fields in both tables and it should be working properly.
What makes me doubt that's the case - you said it was working before. This issue would be present prior to updating as well.

Please tell us if it works.

Kind regards,
Arek

lirit

I think you might missed the point...
Look at the screenshots, the scenario is this:
1. I create a note and set Date field to: 10/10/2010
2. I save the note
3. in the notes listing it shows Date to be: 10/10/2010
4. I edit the note and set Date field to: 10/10/2005
5. I save the note (with some text changed in the note too)
6. in the notes listing it still shows Date to be: 10/10/2010
7. I edit the note again, Date field is showing 10/10/2005 (as if the Date changing took place!)

So I'm saying that it seems that in the listing it doesn't list the correct Date value...

Any ideas?

ethnar

Hey,

I'm sorry, screenshots alone weren't descriptive enough for me.

I can see what's the issue. I looked through Attachment module changes and turns out there was a change to how the date is displayed.
If you want to modify the displayed date, you need to update the date in both note and file tables. Currently system displays latest of the two dates in the table.

Previously it was always note date. In the scenario you posted, utils_attachment_file record is still created, even thou it is empty - the date for file record is set to current time and thus, it's always later than any past date, resulting in the file date being displayed.

Hope this helps,
Arek

lirit

Ahh thanks.
Now it makes sense! :-)

I added a file entry with a newer revision on each save of the note.
Thank you again

Epesi ENS | Epesi Academy | epesi.cloud PaaS | GitHub

Help Me! | Download from SourceForge