Permission field in Premium Sales Opportunity

daniel

Hi,

It is possible to add permission fild in Premium Sales Opportunity module with the full secure function ?

Best regards,

Daniel

ethnar

Hello,

Yes, it's possible and pretty easy to achieve as well.

As usual, it's best to have your own custom module to put the code there so it doesn't conflict with epesi upgrade later:
http://www.epesi.org/index.php?title=Cr ... dule_files

Next thing is to add "Permission" field itself. for that, you'll need just 1 line of code in install procedure:

Utils_RecordBrowserCommon::new_record_field('premium_salesopportunity', array('name'=>'Permission','type'=>'commondata', 'required'=>true, 'param'=>array('order_by_key'=>true,'CRM/Access'),'extra'=>false));

[size=75:3dfupbim]Notice: We're using here the same CommonData array as Contacts, Phonecalls and other do, so we should include CRM/Common in list of required modules, along with SalesOpportunities itself.[/size:3dfupbim]
Next, also in install, you should redirect access callback for Sales Opportunities:

Utils_RecordBrowserCommon::set_access_callback('premium_salesopportunity', array('YourModuleCommon', 'access_salesopportunity'));

You need to define that function access_salesopportunity() in your module common and there you need to put the code that restricts the access to SalesOppotunities based on the value hold in this new field and logged in user. You could take Phonecalls as general guideline. Final code should be something similar to:

public static function access_salesopportunity($action, $param=null){

	$result = Premium_SalesOpportunityCommon::access_salesopportunity($action, $param); // We should use whatever SalesOpportunities was doing on it's own as a base

	if (!$result) return $result;

		// Now the important bits

	switch ($action) {

		case 'browse_crits':

			return array('(!permission'=>2, '|:Created_by'=>Acl::get_user());

		case 'browse':	

			return $result;

		case 'view':

			if (isset($param['permission']) && $param['permission']==2 && $param['created_by']!=Acl::get_user()) return false;

			return $result;

		case 'clone':

		case 'add':		

			return $result;

		case 'edit':	

		case 'delete':

			if ($param['permission']>=1 && $param['created_by']!=Acl::get_user()) return false;

			return $result;

	}

}

And that should do it. 🙂 (code wasn't tested)

I hope this answers your question. 🙂
Arek

daniel

Hi,

Thank you for detailed information. Today I test this system and I will wait until this function will bi added to the next version of the module.

Best regards,

Daniel

daniel

Hi,

I tried to write this simple module, but without success 🙁
Does anyone have any own simple module, so I can analyze the syntax?

Best regards,

Daniel

ethnar

Feel free to attach the code you got so far and we can guide you how to get it working.

Kind regards,
Arek

daniel

Hi,

I made a module according to the description. Installation OK but is error:



There was an error in one of epesi modules. Details are displayed at the bottom of the page, please send this information to system administrator.

Type: 8

Message: Undefined index: permission

File: /usr/local/apache/www/htdocs/crm.****.pl/epesi/modules/Premium/SalesOpportunityPerm/SalesOpportunityPermCommon_0.php

Line=25

error backtrace:

File: /usr/local/apache/www/htdocs/crm.****.pl/epesi/modules/Premium/SalesOpportunityPerm/SalesOpportunityPermCommon_0.php

    line 25

    function called: handle_epesi_error(8, "Undefined index: permission", "/usr/local/apache/www/htdocs/crm.****.pl/epesi/modules/Premium/SalesOpportunityPerm/SalesOpportunityPermCommon_0.php", 25, Array ("view", Array (#4), true))

[PHP core called function]

    function called: access_salesopportunity("view", Array ("1", "1", "2011-09-08", 0), null)

File: /usr/local/apache/www/htdocs/crm.****.pl/epesi/modules/Utils/RecordBrowser/RecordBrowserCommon_0.php

    line 1283

    function called: call_user_func(Array ("Premium_SalesOpportunityPermCommon", "access_salesopportunity"), "view", Array ("1", "1", "2011-09-08", 0), null)

File: /usr/local/apache/www/htdocs/crm.****.pl/epesi/modules/Utils/RecordBrowser/RecordBrowser_0.php

    line 152

    function called: get_access("premium_salesopportunity", "view", Array ("1", "1", "2011-09-08", 0))

File: /usr/local/apache/www/htdocs/crm.****.pl/epesi/modules/Utils/RecordBrowser/RecordBrowser_0.php

    line 1022

    function called: get_access("view", Array ("1", "1", "2011-09-08", 0))

[PHP core called function]

    function called: view_entry("add", null, Array ("1", "1", "2011-09-08", 0))

File: /usr/local/apache/www/htdocs/crm.****.pl/epesi/include/module.php

    line 793

    function called: call_user_func_array(Array (Object (Utils_RecordBrowser), "view_entry"), Array ("add", null, Array (#4)))

File: /usr/local/apache/www/htdocs/crm.****.pl/epesi/include/module.php

    line 713

    function called: get_html_of_module(Object (Utils_RecordBrowser), Array ("add", null, Array (#4)), "view_entry")

File: /usr/local/apache/www/htdocs/crm.****.pl/epesi/modules/Base/Box/Box_0.php

    line 144

    function called: display_module("Object (Utils_RecordBrowser)", Array ("add", null, Array (#4)), "view_entry")

File: /usr/local/apache/www/htdocs/crm.****.pl/epesi/include/epesi.php

    line 209

    function called: body()

File: /usr/local/apache/www/htdocs/crm.****.pl/epesi/include/epesi.php

    line 265

    function called: go(Object (Base_Box))

File: /usr/local/apache/www/htdocs/crm.****.pl/epesi/process.php

    line 32

    function called: process("__action_module__=%2FBase_Box%7C0%2FBase_User_Login%7Clogin&%2FBase_Box%7C0%2FBase_User_Login%7Clogin_logout=1", false)

Line 25 of SalesOpportunityPermCommon_0.php:

if ($param['permission']==2 && $param['created_by']!=Acl::get_user()) return false;

Best regards,

Daniel

ethnar

My bad, I forgot that view event is also triggered for adding records and since phonecalls and other define default for the field, it's not a problem there.

Fix is pretty easy - replace that line with

if (isset($param['permission']) && $param['permission']==2 && $param['created_by']!=Acl::get_user()) return false;

No need to reinstall the module.

I'll update original code. I apologize for inconvenience caused.

Kind regards,
Arek

daniel

Hi,

Thank you for your help:) Everything works.

Best regards,

Daniel

daniel

Hi,

I have problem with instal my module on Epesi 1.4.2.

Screen with error.

In the old version of Epesi the module install correctly.

Best regards,

Daniel

ajb

Yes - there is no more set_access_callback method, so your code is not valid for current EPESI release.

Defining access to records has changed. Now access is stored in database instead of PHP code (in callback as previous). You can edit permissions in Menu/Administrator/RecordBrowser -> set tab to permissions or rewrite your module to use new methods to set permission rules.

If you would like to rewrite your module, to add this rules during install, then use Utils_RecordBrowserCommon::add_access method.

Remove your callback in Common file. Change install method in Install file - remove set_access_callback and here put add_access methods.

Here is example from Tasks, where there is also permission field

Utils_RecordBrowserCommon::add_access('task', 'view', 'ACCESS:employee', array('(!permission'=>2, '|employees'=>'USER'));

Utils_RecordBrowserCommon::add_access('task', 'add', 'ACCESS:employee');

Utils_RecordBrowserCommon::add_access('task', 'edit', 'ACCESS:employee', array('(permission'=>0, '|employees'=>'USER', '|customers'=>'USER'));

Utils_RecordBrowserCommon::add_access('task', 'delete', 'ACCESS:employee', array(':Created_by'=>'USER_ID'));

Utils_RecordBrowserCommon::add_access('task', 'delete', array('ACCESS:employee','ACCESS:manager'));

You have to change this code to fullfil your requirements. It's copied from Tasks and may not be exactly what you want.

To get know more about go to http :// your installation url / modules/Utils/RecordBrowser/help/permissions.html

Regards,
Adam

Epesi ENS | Epesi Academy | epesi.cloud PaaS | GitHub

Help Me! | Download from SourceForge