About notes

krusso

Hi. Did not find this or similar case in forum.
I have created module 'custom_contracts'. With it is almost OK. Then I've installed notes addon Utils_AttachmentCommon::new_addon('custom_contracts'). It's ok too, every contract has his own note or notes. The strange thing appeared when I reinstalled my module 'contracts' : I've created new test contract and found old note which was created for another test contract before reinstallation of my module. Then I've created several test contracts, lets say xxx, yyy and zzz and created notes for them notexxx, noteyyy and notezzz respectively. Then I reinstalled my module again. And created new test contracts again, but with different No.: 1xx, 1yy and 1zz and found previous notes (notexxx with 1xx, noteyyy with 1yy and notezzz with 1zz). And found all deleted notes, when made selection to show all deleted notes. Is it normal or it is my mistakenly made coding? I've added Utils_AttachmentCommon::delete_addon('custom_contracts') into uninstall section. Thank you in advance

ajb

Yes, you've deleted the "addon", but not the notes 🙂
Proper uninstall code:

        $x = 'custom_contracts';

        Utils_AttachmentCommon::persistent_mass_delete($x);

        Utils_AttachmentCommon::delete_addon($x);

krusso

[quote="ajb":jk4msvn2]Yes, you've deleted the "addon", but not the notes 🙂
Proper uninstall code:

        $x = 'custom_contracts';

        Utils_AttachmentCommon::persistent_mass_delete($x);

        Utils_AttachmentCommon::delete_addon($x);

[/quote:jk4msvn2]

Thank you again. Works fine. With your help everything seems so easy 🙂 The uninstall method which I applied was taken from sales opportunities, but it looks like I've copied code without learning.

ajb

It's also possible that some of the uninstall methods may be wrong as they are barely used. Especially for some core modules.

Epesi ENS | Epesi Academy | epesi.cloud PaaS | GitHub

Help Me! | Download from SourceForge