Phonecalls Applet

bdwmq8

I am on version 1.7.2. Could you let me know how to get rid of the space between the country dialing code and the actual phone number on the applet. This space cause a problem to our dialer in that it adds %20 instead of the space when the number is transfered to the dialer. This, to the best of my knowledge, doesn't happen anywhere else with phone numbers in Epesi.
Thanks
Alan

ajb

Do you use custom dialer or callto: protocol?
It's strange that only applet is affected, because it uses the same method as browse view.

bdwmq8

Hi - I think it is a custom dialer. This is the site https://www.justremotephone.com/
and it works wonerfully with Epesi and Android phones - except on that applet which i suspect has been programmed to have a space between code and number.
Thanks
Alan

ajb

I was asking about the dialer used in EPESI. Menu -> My Settings -> Control Panel -> Dialing.
You could try to inspect generated link to make sure it's the same or different in applet / browse mode.

We put space after calling code - that's right. And in link you'll have a space, but it should be handled properly by the dialing app. You can remove the space in the code, but I'm not sure does this situation requires me to change the core code or not.

bdwmq8

Hi yes sorry - dialing method is "skype and other 'callto' protocol applications".
The dialing app does not handle the space well. For me it would be great if that space was removed from the core code. If anyone requires the space it could easily be added manually via common data ->calling codes.
Thanks
Alan

ajb

The real problem here is why space in other views is handled properly and in the applet view it's not.
Edit file: modules/CRM/PhoneCall/PhoneCallCommon_0.php line ~234

		if($number && strpos($number,'+')===false) {
			if($contact['country']) {
				$calling_code = Utils_CommonDataCommon::get_value('Calling_Codes/'.$contact['country']);
				if($calling_code)
					$number = $calling_code.' '.$number;
			}
		}

remove space in the join:

			if($contact['country']) {
				$calling_code = Utils_CommonDataCommon::get_value('Calling_Codes/'.$contact['country']);
				if($calling_code)
					$number = $calling_code.$number;
			}
		}

Best regards,
Adam

bdwmq8

Excellent - that works for me!
Thanks Adam
Best
Alan

ajb

I've fixed this code to be "better"

https://github.com/Telaxus/EPESI/commit/02dacd1ff2d8f08894179c1fc6bcd205a9b7338c

Epesi ENS | Epesi Academy | epesi.cloud PaaS | GitHub

Help Me! | Download from SourceForge