EPESI 1.8.0: Is anything wrong with Utils_LeightboxPrompt::body()?

praski

Hello.

There are changes with Utils_LeightboxPrompt behaviour from version 1.7.2 to 1.8.0

In 1.7.2 version code:

$rb_obj = Utils_RecordBrowser::$rb_obj;
$lb = $rb_obj->init_module('Utils_LeightboxPrompt');
$form = $rb_obj->init_module('Libs_QuickForm');
$form->addElement('datepicker','id_data','Realisation date:');
$form->addRule('id_data', __('Required'), 'required');
$form->setDefaults(array('id_data'=>time()));
$lb->add_option(null, null, null, $form); //$key, $label, $icon, $form
$rb_obj->display_module($lb,array(__('Realisation date:'),array(),'',false));

displayed Leightbox with only my form (in one step).

From 1.8.0 there are 2 steps:
first displays empty key (not defined by me and unneded), then only my form.

This is pernament change or bug? Should I always define key from 1.8.0?

Best regards
Praski

ajb

Yes you should define a key. It won't be shown, but it's required for the code to work properly.

$lb->add_option('setdate', null, null, $form); //$key, $label, $icon, $form

Best regards,
Adam

praski

No.
It is not working.
The problem is somewhere else. There are changes in code from previous version. I suppose something is ommited.

Best regards
Praski.

ghristov

I have absolutely same code with 1.8.0 and it works fine (option key defined)

praski

Hello ghristov. I have waited for your answer :-)
My installations have been upgraded from 1.7.2. Maybe this is a clue.
Tests were performed in Chrome incognito mode.

I have no idea what could open absolutely empty leightbox window (when I define option key like in Adam's example there is no key at all).

Best regards.
Praski

ghristov

I just tested in incognito mode and it works as well.

Maybe you try:
- rebuild common cache (Admin Tools->Rebuild common cache & default theme)
- refresh your browser
- post a more detailed description of what happens in your case (could not quite understand)

Best regards,
Georgi

praski

Hello.
Below screens described my problem with epesi 1.8.0:

In 1.7.2 (and below f.e. 1.6.5)

In 1.8.0 the same code generate 2 leightboxes::

first unneded by me with empty key:

And second (after click on empty key on screen) - this is screen I expect.

When I define nonexist key like adam wrote:

$lb->add_option('setdate', null, null, $form); //$key, $label, $icon, $form

The first unneded screen in 1.8.0 is empty (even without empty key), so I can not enter to second screen.

Best regards
Praski.

ghristov

Hi Praski,

Now your problem is clear but I do not see a reason for it.
I see that the code you posted here is an extract as in actual you have also a parameter $additional_info which is the text shown below the form.
I have made a pull request with modification which allows using empty option key under:
https://github.com/Telaxus/EPESI/pull/118/commits/a34d0a9f53dc5cfd69c4552fa0c22b49ce3475ba

Please use the code and let us know if any difference.

Brgds,
Georgi

praski

Hi GHristov

Much better. It's mean now is correct. With $additional_info and without. ;-)

Thanks a lot.

Best regards
Praski.

ajb

Really strange. In fact I don't see the reason why ghristov's pull request fixes the issue. Maybe you've got some runtime cache and it has been refreshed after you've modified this file?

ghristov

Me also - no reason that this would fix it.
But I made the fix as I was searching in present original code an example that @praski can test on his installation and figured out that Base_Lang_Administator uses Utils_LeightboxPrompt and it did not work as intended with empty option key so backward compatibility is necessary.

Best regards,
Georgi

Epesi ENS | Epesi Academy | epesi.cloud PaaS | GitHub

Help Me! | Download from SourceForge