Custom record browser and account manager.

jcvieira

Hi there,

Im currently using epesi 1.8.1 with the account manager module installed.

I have a custom record browser that ive migrated from older versions and since the upgrade to the current version that im only able to see records that my account has created even tought i have a field "client" that is linked on the company record.

On the rb permissions i have the following:

VIEW : Client is set to record where Account Manager is equal to User Contact

But the records dont show if the created_by field differs from account manager...

Any ideas?

Thank you for your assistance.

ajb

I can't visualise your issue... i don't get it.

Please provide more details, like all access rules, some example.

jcvieira

Hi ajb, thansk for comming back, will try to explain in depth:

I have a custom module that contains a RecordBrowser, this rb contains a couple of regular fields, one of them is the client field that fetches information from the company.

If i create an entry on this RB it shows up in the view with no problems.

The issue is that i want that the information to be glued with the company regardless of the person who created the entry (hence the client field) and the problem occurs if i change the Account Manager in the company to a diferent rep the destination person no longer visualizes that record.

I hope i have been clear enought on the matter, please let me know.

Thanks in advance.

jcvieira

One last thinng the View Rule is defined above;

ajb

But beside of the above rule you've got another rule that is like
View: record created by my user
?

I've tested this permission on contacts recordset. I've got the rules:

(Permission is not equal to Private or Created by is equal to User Login) and Company Name is set to record where Account Manager is equal to User Contact

and it works as expected. The only thing to notice is that if you're super admin, then you'll get all access levels automatically (employee, manager and any other added)

Maybe please try to edit this rule. Maybe something has changed in the storage, but it shouldn't.

jcvieira

Hi AJB thanks for your assistance, im attaching a print scren to see if you can better understand whats happening...
Thanks

jcvieira

By the way permissions is set to employe only... Just ignore the Manager, as i was testing...

ajb

There are some other things to check.

I assume that those screenshots are made from the same account and this user (Ferreira Maria) can see the company?
Please show me the account manager raw value from the database for this record.
Please show the account manager field definition - is it single or multi select?

Please get Contact ID of Ferreira Maria and execute such commands (php shell)

return Utils_RecordBrowserCommon::get_records('TPN_SM_BPro',
    array('client[account_manager]' => <contact id>)); // e.g. 34

Then execute something similar

return Utils_RecordBrowserCommon::get_records('TPN_SM_BPro',
    array('client[account_manager]' => 'contact/<contact id>')); // e.g. 'contact/34'

Now execute similar query but with magic value that should be replaced. You have to be logged in as this user - so I do this in the code, because you can't run shell as normal user.

// login as user
$maria_contact = CRM_ContactsCommon::get_contact(<contact id>); // e.g. 34
Base_AclCommon::set_user($maria_contact['login']);
// test query
return Utils_RecordBrowserCommon::get_records('TPN_SM_BPro',
    array('client[account_manager]' => 'USER'));

It should give the same result as the previous queries.

Waiting for your report.

Best regards,
Adam

jcvieira

Hi AJB, I think i have everything you requested bellow:

Point 5. provides an array of results including the ones that dont seem to be displayed.

Let me know.

Thank you for your time.

ajb

Hi, sorry for the lag in the response - I was away yesterday.

Still I have no idea, why it doesn't work.

Please get the sql that's executed behind the scenes with this in the epesi shell:

$maria_contact = CRM_ContactsCommon::get_contact(2052); // maria contact
Base_AclCommon::set_user($maria_contact['login']);
return Utils_RecordBrowserCommon::build_query('TPN_SM_BPro',
    array('client[account_manager]' => 'USER'));

Maybe it will show us what's wrong. I reviewed recent commits to see if I made any fixes to the query or access, but I don't see any changes.

jcvieira

Hi, thank your for assistance ajb.

Here is the output of the command above:

array(5) { ["sql"]=> string(1708) " TPN_SM_BPro_data_1 AS r WHERE r.active=1 AND (((r.f_client IS NOT NULL AND (r.f_client IN (11,19,29,59,129,247,410,461,498,525,542,611,626,632,689,740,743,855,949,997,1106,1121,1171,1233,1250,1282,1288,1404,1451,1457,1585,1639,1665,1700,1703,1806,1810,1813,1816,1834,1849,1998,2006,2017,2023,2083,2087,2095,2111,2167,2188,2209,2226,2241,2252,2262,2263,2284,2295,2301,2348,2382,2387,2400,2511,2538,2547,2559,2562,2579,2582,2600,2612,2613,2614,2615,2616,2617,2618,2619,2623,2625,2626,2627,2639,2646,2651,2652,2700,2726,2729,2776,2804,2817,2821,2822,2826,2831,2840,2843,2846,2855,2859,2864,2868)))) AND (((r.f_client IS NOT NULL AND (r.f_client IN (11,19,29,59,129,247,410,461,498,525,542,611,626,632,689,740,743,855,949,997,1106,1121,1171,1233,1250,1282,1288,1404,1451,1457,1585,1639,1665,1700,1703,1806,1810,1813,1816,1834,1849,1998,2006,2017,2023,2083,2087,2095,2111,2167,2188,2209,2226,2241,2252,2262,2263,2284,2295,2301,2348,2382,2387,2400,2511,2538,2547,2559,2562,2579,2582,2600,2612,2613,2614,2615,2616,2617,2618,2619,2623,2625,2626,2627,2639,2646,2651,2652,2700,2726,2729,2776,2804,2817,2821,2822,2826,2831,2840,2843,2846,2855,2859,2864,2868)))) OR (((r.f_client IS NOT NULL AND (r.f_client IN (11,19,29,59,129,247,410,461,498,525,542,611,626,632,689,740,743,855,949,997,1106,1121,1171,1233,1250,1282,1288,1404,1451,1457,1585,1639,1665,1700,1703,1806,1810,1813,1816,1834,1849,1998,2006,2017,2023,2083,2087,2095,2111,2167,2188,2209,2226,2241,2252,2262,2263,2284,2295,2301,2348,2382,2387,2400,2511,2538,2547,2559,2562,2579,2582,2600,2612,2613,2614,2615,2616,2617,2618,2619,2623,2625,2626,2627,2639,2646,2651,2652,2700,2726,2729,2776,2804,2817,2821,2822,2826,2831,2840,2843,2846,2855,2859,2864,2868)))))))" ["vals"]=> array(0) { } ["order"]=> string(0) "" ["tab"]=> string(23) "TPN_SM_BPro_data_1 AS r" ["where"]=> string(1677) "r.active=1 AND (((r.f_client IS NOT NULL AND (r.f_client IN (11,19,29,59,129,247,410,461,498,525,542,611,626,632,689,740,743,855,949,997,1106,1121,1171,1233,1250,1282,1288,1404,1451,1457,1585,1639,1665,1700,1703,1806,1810,1813,1816,1834,1849,1998,2006,2017,2023,2083,2087,2095,2111,2167,2188,2209,2226,2241,2252,2262,2263,2284,2295,2301,2348,2382,2387,2400,2511,2538,2547,2559,2562,2579,2582,2600,2612,2613,2614,2615,2616,2617,2618,2619,2623,2625,2626,2627,2639,2646,2651,2652,2700,2726,2729,2776,2804,2817,2821,2822,2826,2831,2840,2843,2846,2855,2859,2864,2868)))) AND (((r.f_client IS NOT NULL AND (r.f_client IN (11,19,29,59,129,247,410,461,498,525,542,611,626,632,689,740,743,855,949,997,1106,1121,1171,1233,1250,1282,1288,1404,1451,1457,1585,1639,1665,1700,1703,1806,1810,1813,1816,1834,1849,1998,2006,2017,2023,2083,2087,2095,2111,2167,2188,2209,2226,2241,2252,2262,2263,2284,2295,2301,2348,2382,2387,2400,2511,2538,2547,2559,2562,2579,2582,2600,2612,2613,2614,2615,2616,2617,2618,2619,2623,2625,2626,2627,2639,2646,2651,2652,2700,2726,2729,2776,2804,2817,2821,2822,2826,2831,2840,2843,2846,2855,2859,2864,2868)))) OR (((r.f_client IS NOT NULL AND (r.f_client IN (11,19,29,59,129,247,410,461,498,525,542,611,626,632,689,740,743,855,949,997,1106,1121,1171,1233,1250,1282,1288,1404,1451,1457,1585,1639,1665,1700,1703,1806,1810,1813,1816,1834,1849,1998,2006,2017,2023,2083,2087,2095,2111,2167,2188,2209,2226,2241,2252,2262,2263,2284,2295,2301,2348,2382,2387,2400,2511,2538,2547,2559,2562,2579,2582,2600,2612,2613,2614,2615,2616,2617,2618,2619,2623,2625,2626,2627,2639,2646,2651,2652,2700,2726,2729,2776,2804,2817,2821,2822,2826,2831,2840,2843,2846,2855,2859,2864,2868)))))))" }

ajb

After some simplifications of the query, those are the records she should see.
Execute this in the sql console if you can ( you can also execute the original query from your response, but add select * ):

SELECT * FROM TPN_SM_BPro_data_1 AS r WHERE r.active=1 AND r.f_client IS NOT NULL AND r.f_client IN (11,19,29,59,129,247,410,461,498,525,542,611,626,632,689,740,743,855,949,997,1106,1121,1171,1233,1250,1282,1288,1404,1451,1457,1585,1639,1665,1700,1703,1806,1810,1813,1816,1834,1849,1998,2006,2017,2023,2083,2087,2095,2111,2167,2188,2209,2226,2241,2252,2262,2263,2284,2295,2301,2348,2382,2387,2400,2511,2538,2547,2559,2562,2579,2582,2600,2612,2613,2614,2615,2616,2617,2618,2619,2623,2625,2626,2627,2639,2646,2651,2652,2700,2726,2729,2776,2804,2817,2821,2822,2826,2831,2840,2843,2846,2855,2859,2864,2868)

All of those client ids should be the companies with account manager set to Maria. Are they? I see id=11, so I suppose they are.

If above query returns non empty set of results (with active records, etc), then maybe PHP runtime validation is broken and removes those records. Then please try to replace file modules/Utils/RecordBrowser/CritsValidator.php with the recent one (raw file)

If it won't help I have no idea right now what's wrong.

jcvieira

Yes the query above returns the proper results, how can the RB doesnt? Where can we change this behaviour in the RB?

Tried to replace the file, made no diff.

Is there any other thing we can try?

ajb

I have no idea right now. The only possibility right now is to debug the issue within the code.

You can try to comment out this line (modules/Utils/RecordBrowser/RecordBrowserCommon_0.php:1601)
But please have in mind that it can give some view access for the records for different users.

            if($admin || self::get_access($tab,'view',$r)) $records[$row['id']] = $r;

and add assignment without checking rules

            //if($admin || self::get_access($tab,'view',$r)) $records[$row['id']] = $r;
            $records[$row['id']] = $r;

Then get records again or just navigate in GUI.

$maria_contact = CRM_ContactsCommon::get_contact(2052); // maria contact
Base_AclCommon::set_user($maria_contact['login']);
return Utils_RecordBrowserCommon::get_records('TPN_SM_BPro',
    array('client[account_manager]' => 'USER'));

jcvieira

Still no luck with this AJB, thanks for your time anyway...
Will probably have to make a custom HTML module to deal with this matter and show the records missing...Not sure on how will acomplish this tought...

jcvieira

Hi ajb, stil regarding this issue, can you please point to me how can i "inject" the proper IDS for those RB's ?
On which file? Which function / method should be doing it? I realy need to sort this problem out as soon as possible.

Thank you

Epesi ENS | Epesi Academy | epesi.cloud PaaS | GitHub

Help Me! | Download from SourceForge